qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 0/5] vhost-user block device backend implementation


From: Coiby Xu
Subject: Re: [PATCH v9 0/5] vhost-user block device backend implementation
Date: Mon, 17 Aug 2020 16:23:52 +0800

On Thu, Jun 18, 2020 at 09:28:44AM +0100, Stefan Hajnoczi wrote:
On Tue, Jun 16, 2020 at 02:52:16PM +0800, Coiby Xu wrote:
On Sun, Jun 14, 2020 at 12:16:28PM -0700, no-reply@patchew.org wrote:
> Patchew URL: 
https://patchew.org/QEMU/20200614183907.514282-1-coiby.xu@gmail.com/
>
>
>
> Hi,
>
> This series failed the asan build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce 
it
> locally.
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
> === TEST SCRIPT END ===
>
>  CC      stubs/vm-stop.o
>  CC      ui/input-keymap.o
>  CC      qemu-keymap.o
> /tmp/qemu-test/src/util/vhost-user-server.c:142:30: error: use of undeclared 
identifier 'VHOST_MEMORY_MAX_NREGIONS'
>                             VHOST_MEMORY_MAX_NREGIONS, nfds + nfds_t);
>                             ^
>
> The full log is available at
> 
http://patchew.org/logs/20200614183907.514282-1-coiby.xu@gmail.com/testing.asan/?type=message.

I couldn't re-produce this error locally for both docker-test-quick@centos7
and this docker test. And I can't see any reason for this error to occur since
VHOST_MEMORY_MAX_NREGIONS is defined in contrib/libvhost-user/libvhost-user.h
which has been included by util/vhost-user-server.h.

Using G_N_ELEMENTS(vmsg->fds) instead of VHOST_MEMORY_MAX_NREGIONS is an
even cleaner fix.

Stefan

Thank you for this cleaner fix!

--
Best regards,
Coiby



reply via email to

[Prev in Thread] Current Thread [Next in Thread]