[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/18] hw/sd: sdhci: Make sdhci_poweron_reset() internal visi
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 09/18] hw/sd: sdhci: Make sdhci_poweron_reset() internal visible |
|
Date: |
Sun, 16 Aug 2020 13:06:34 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 8/16/20 10:50 AM, Bin Meng wrote:
> Hi Philippe,
>
> On Sat, Aug 15, 2020 at 3:51 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
>>
>> On 8/14/20 6:40 PM, Bin Meng wrote:
>>> From: Bin Meng <bin.meng@windriver.com>
>>>
>>> sdhci_poweron_reset() might be needed for any SDHCI compatible
>>> device that is built on top of the generic SDHCI device.
>>
>> NAck. Please use device_legacy_reset() instead.
>>
>> In next patch:
>>
>> device_legacy_reset(DEVICE(&sdhci->slot));
>>
>
> The function comments say this API is deprecated.
>
> /**
> * device_legacy_reset:
> *
> * Reset a single device (by calling the reset method).
> * Note: This function is deprecated and will be removed when it becomes
> unused.
> * Please use device_cold_reset() now.
> */
>
> Should we use device_cold_reset() here?
Oops yes, certainly.
>
> Regards,
> Bin
>
[PATCH 14/18] hw/net: cadence_gem: Add a new 'phy-addr' property, Bin Meng, 2020/08/14