Re: [PATCH 6/7] hw/ide/pci: Replace magic '512' value by BDRV_SECTOR_SIZE

[Li Qiang]

Philippe Mathieu-Daudé <f4bug@amsat.org> 于2020年8月14日周五 下午4:33写道：
>
> Use self-explicit definitions instead of magic '512' value.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Li Qiang <liq3ea@gmail.com>

> ---
>  hw/ide/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ide/pci.c b/hw/ide/pci.c
> index 5e85c4ad17..b50091b615 100644
> --- a/hw/ide/pci.c
> +++ b/hw/ide/pci.c
> @@ -138,7 +138,7 @@ static int32_t bmdma_prepare_buf(const IDEDMA *dma, 
> int32_t limit)
>      int l, len;
>
>      pci_dma_sglist_init(&s->sg, pci_dev,
> -                        s->nsector / (BMDMA_PAGE_SIZE / 512) + 1);
> +                        s->nsector / (BMDMA_PAGE_SIZE / BDRV_SECTOR_SIZE) + 
> 1);
>      s->io_buffer_size = 0;
>      for(;;) {
>          if (bm->cur_prd_len == 0) {
> --
> 2.21.3
>
>