Re: [PATCH 000/147] Meson integration for 5.2

[Stefano Garzarella]

On Mon, Aug 10, 2020 at 07:06:38PM +0200, Paolo Bonzini wrote:
> This version is substantially less "draft-like", and the diffstat
> is actually quite large with Thursday's draft.
> 
> The changes are as follows:
> - updated oss-fuzz build script
> - various cases fixed that broke depending on present/absent dependencies
> - all build scripts handle --python correctly
> - git submodules properly updated before running meson
> - no warnings from Meson master (will be 0.56.0), one from upcoming 0.55.1
> - installation matches current build system
> - fixes for virtio-vga broken merge
> - includes updated s390-ccw patch from Thomas
> - less noisy "make check"
> - tested with GitLab CI, BSD VM builds and various Docker builds
> - input-keymap files properly regenerated
> 
> Of our supported build platforms, only Mac OS and non-x86 hosts are
> still untested.  But I guess this might finally count as a v1.

I tested on macOS 10.15 and it seems to be going very well, great job!

I've only had a few warnings during the 'configure':

    ...
    Host machine cpu family: x86_64
    Host machine cpu: x86_64
    ../meson.build:9: WARNING: Module unstable-keyval has no backwards or 
forwards compatibility and might not exist in future releases.
    Program sh found: YES
    Program python3 found: YES (/usr/local/bin/python3)
    ../meson.build:42: WARNING: add_languages is missing native:, assuming 
languages are wanted for both host and build.
    Objective-C compiler for the host machine: cc (clang 11.0.3)
    Objective-C linker for the host machine: cc ld64 556.6
    ...
    Found ninjatool-1.8 at /Users/stefano/repos/qemu-paolo/build/ninjatool
    WARNING: custom_target 'shared QAPI source files' has more than one output! 
Using the first one.
    WARNING: custom_target 'QGA QAPI files' has more than one output! Using the 
first one.
    WARNING: custom_target 'QAPI files for qemu-storage-daemon' has more than 
one output! Using the first one.
    WARNING: custom_target 'tools man pages' has more than one output! Using 
the first one.
    WARNING: custom_target 'system man pages' has more than one output! Using 
the first one.

Let me know if you need the full output.

The build went well, the only thing that didn't work for me is make clean:
    $ make clean
    /usr/local/bin/python3 -B /Users/stefano/repos/qemu-paolo/meson/meson.py 
introspect --tests | /usr/local/bin/python3 -B scripts/mtest2make.py > 
Makefile.mtest
    ./ninjatool -t ninja2make --clean --omit dist uninstall < build.ninja > 
Makefile.ninja
    Cleaning...
    make: rm: Argument list too long
    make: *** [ninja-clean] Error 1

This was my test:
    git clone https://gitlab.com/bonzini/qemu.git --branch meson-poc-next
    cd qemu
    git submodule update --init
    mkdir build
    cd build
    ../configure
    make -j8
    ./qemu-system-x86_64 --nographic
    make clean

Let me know if I need to run any more specific tests.

Thanks,
Stefano