Re: [PATCH v3 2/3] async: always set ctx->notified in aio_notify()

[Stefan Hajnoczi]

On Thu, Aug 06, 2020 at 03:45:33PM +0200, Paolo Bonzini wrote:
> On 06/08/20 15:18, Stefan Hajnoczi wrote:
> > +    atomic_set(&ctx->notified, false);
> > +
> > +    /*
> > +     * Write ctx->notified before reading e.g. bh->flags.  Pairs with 
> > smp_mb in
> > +     * aio_notify.
> > +     */
> > +    smp_wmb();
> 
> Sorry I was not clear: the memory barrier has to be smp_mb(), but the
> comment has to say smp_wmb().  No need to repost for this.

Ah, right! I'll fix it up when merging. Thanks!

Stefan

signature.asc
Description: PGP signature