[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] [PATCH v2] gdbstub: add support to Xfer:auxv:read: packet

From: Alex Bennée
Subject: Re: [PATCH] [PATCH v2] gdbstub: add support to Xfer:auxv:read: packet
Date: Mon, 03 Aug 2020 12:26:58 +0100
User-agent: mu4e 1.5.5; emacs 28.0.50

Lirong Yuan <yuanzi@google.com> writes:

> This allows gdb to access the target’s auxiliary vector,
> which can be helpful for telling system libraries important details
> about the hardware, operating system, and process.
> Signed-off-by: Lirong Yuan <yuanzi@google.com>

I cleaned up the test a little:

modified   tests/tcg/multiarch/gdbstub/test-qxfer-auxv-read.py
@@ -22,13 +22,9 @@ def report(cond, msg):
 def run_test():
     "Run through the tests one by one"
-    cond = True
-    try:
-      gdb.execute("info auxv")
-    except (gdb.error, AttributeError):
-      cond = False
-    report(cond, "Display the auxiliary vector of the inferior.")
+    auxv = gdb.execute("info auxv", False, True)
+    report(isinstance(auxv, str), "Fetched auxv from inferior")
+    report(auxv.find("sha1"), "Found test binary name in auxv")
 # This runs as the script it sourced (via -x, via run-test.py)

Queued to gdbstub/next, thanks.

Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]