[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->ioth
From: |
Lukas Straub |
Subject: |
[PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread |
Date: |
Fri, 31 Jul 2020 07:06:04 +0200 |
s->iothread is checked for NULL on object creation in colo_compare_complete,
so it's guaranteed not to be NULL.
This resolves a false alert from Coverity (CID 1429969).
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
net/colo-compare.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index cc15f23dea..2c20de1537 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -1442,9 +1442,7 @@ static void colo_compare_finalize(Object *obj)
qemu_chr_fe_deinit(&s->chr_notify_dev, false);
}
- if (s->iothread) {
- colo_compare_timer_del(s);
- }
+ colo_compare_timer_del(s);
qemu_bh_delete(s->event_bh);
@@ -1470,9 +1468,7 @@ static void colo_compare_finalize(Object *obj)
g_hash_table_destroy(s->connection_track_table);
}
- if (s->iothread) {
- object_unref(OBJECT(s->iothread));
- }
+ object_unref(OBJECT(s->iothread));
g_free(s->pri_indev);
g_free(s->sec_indev);
--
2.20.1
pgpAZwRi8RMRI.pgp
Description: OpenPGP digital signature
- [PATCH] colo-compare: Remove superfluous NULL-pointer checks for s->iothread,
Lukas Straub <=