qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] trace/simple: Allow enabling simple traces from command line


From: Josh DuBois
Subject: Re: [PATCH] trace/simple: Allow enabling simple traces from command line
Date: Thu, 30 Jul 2020 17:50:09 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

Well, this is a bit embarrassing.  The patch below simply re-introduced the bug which the Fixes: line was trying to fix in the first place.

I.e, :

- with my patch (just committed as 1b7157be3a8c4300fc8044d40f4b2e64a152a1b4) applied, a QEMU built with simple tracing will always produce a trace-<pid> file, regardless of whether traces were asked for.

- after db25d56c014aa1a96319c663e0a60346a223b31e, which my patch was supposed to "fix," QEMU will not produce a trace file unless asked, I believe, via the monitor.  Enabling traces is, near as I can tell, simply impossible via the command-line in that case.

- prior to db25d56c014aa1a96319c663e0a60346a223b31e, just like today, QEMU built with simple tracing will always produce a trace-<pid> file, regardless of whether the user asks for traces at runtime.

I'm sorry for the mess.  Having stepped in it already, I'm  open to trying to track it down and fix it properly.  I imagine perhaps few people truly care, since traces require a special build and are probably only being done by developers anyway.  (And the original message for db25d56c014aa1a96319c663e0a60346a223b31e said it had been "broken" for an unknown period of time).

I'm brand new around here so I'll leave it to others whether it's better to revert and have traces impossible to enable from the cli (as I say, I think they're only possible from the monitor prior to my "fix" ) or to leave it be.

If I resubmit, I'll try to test a little more next time.  I just wanted my traces to work. ;)

On 7/29/20 8:05 AM, Stefan Hajnoczi wrote:
On Thu, Jul 23, 2020 at 12:33:59AM -0500, Josh DuBois wrote:
The simple trace backend is enabled / disabled with a call
to st_set_trace_file_enabled().  When initializing tracing
from the command-line, this must be enabled on startup.
(Prior to db25d56c014aa1a9, command-line initialization of
simple trace worked because every call to st_set_trace_file
enabled tracing.)

Fixes: db25d56c014aa1a96319c663e0a60346a223b31e
Signed-off-by: Josh DuBois <josh@joshdubois.com>
---
  trace/control.c | 1 +
  1 file changed, 1 insertion(+)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]