[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1?] qapi/block-core.json: Remove stale description of '
From: |
Kashyap Chamarthy |
Subject: |
Re: [PATCH for-5.1?] qapi/block-core.json: Remove stale description of 'blockdev-add' |
Date: |
Wed, 29 Jul 2020 11:22:30 +0200 |
On Tue, Jul 28, 2020 at 09:50:39AM -0500, Eric Blake wrote:
> On 7/28/20 9:32 AM, Kashyap Chamarthy wrote:
[...]
> > [1] https://lists.nongnu.org/archive/html/qemu-discuss/2020-07/msg00071.html
> > -- equivalent to "-drive if=ide,id=disk0....."
> >
> > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> > Identified-by: Kevin Wolf <kwolf@redhat.com>
>
> This would be our first use of this unusual tag name; more typical is
> Suggested-by or Reported-by.
Yes, I agree, using predictable tags is better; so 'Suggested-by' is
good.
(We perhaps don't have as many 'unusual tags' as the kernel does :-) —
https://lwn.net/Articles/503829/)
> Is it worth a 'Fixes: be4b67bc7d' line?
Sure, including the provenance is always useful for later `git`
sleuthing.
[...]
> > -# Creates a new block device. If the @id option is given at the top level,
> > a
> > -# BlockBackend will be created; otherwise, @node-name is mandatory at the
> > top
> > -# level and no BlockBackend will be created.
> > +# Creates a new block device.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks; shall I spin a v2? (I agree with both your suggestions above.)
> As a doc fix, it is safe for 5.1, but given the timing of -rc2 today, it's
> also okay if it slips into 5.2.
Yeah, 5.1 or 5.2, both are fine by me.
[...]
--
/kashyap