[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror
From: |
Thomas Huth |
Subject: |
Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror |
Date: |
Tue, 28 Jul 2020 08:43:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 27/07/2020 12.57, Daniel P. Berrangé wrote:
> On Fri, Jul 24, 2020 at 05:50:47PM +0100, Peter Maydell wrote:
>> On Fri, 24 Jul 2020 at 17:46, Philippe Mathieu-Daudé <philmd@redhat.com>
>> wrote:
>>> I guess we were expecting the distrib to update the pkg.
>>
>> Apple's view is that you shouldn't be using the sasl header
>> at all but instead their proprietary crypto library APIs, so
>> I wouldn't expect them to ever ship something without the
>> deprecation warnings.
>
> So from pov of our CI, it seems the right answer is to modify the
> cirrus.yml to install libsasl2 from homebrew:
>
> https://formulae.brew.sh/formula-linux/libsasl2
Ok, that one confused me for quite a while, since brew refused to find
it in the macOS jobs on Cirrus-CI. The solution: This is not a macOS
package, but a Linux package! Homebrew is apparently also available for
Linux. There is no libsasl package in homebrew for macOS.
So what to do now? I think introducing a libsasl submodule to QEMU just
for compiling this code on macOS without warnings is also overkill. And
if I got the answers here right, --disable-sasl is also disliked (since
this code likely should still be (compile-)tested on macOS).
So I think I'll go for the same trick as Peter is using for his tests
and use --extra-cflags='-Werror -Wno-error=deprecated-declarations'.
Thomas
- [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, (continued)
- [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Thomas Huth, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Daniel P . Berrangé, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Philippe Mathieu-Daudé, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Daniel P . Berrangé, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Thomas Huth, 2020/07/27
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Peter Maydell, 2020/07/27
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Thomas Huth, 2020/07/27
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Peter Maydell, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Christian Schoenebeck, 2020/07/24
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Daniel P . Berrangé, 2020/07/27
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror,
Thomas Huth <=
- Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Daniel P . Berrangé, 2020/07/28
Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Peter Maydell, 2020/07/24
Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror, Ed Maste, 2020/07/26
[PATCH 1/3] configure: Fix atomic64 test for --enable-werror on macOS, Thomas Huth, 2020/07/24
[PATCH 3/3] cirrus.yml: Update the macOS jobs to Catalina, Thomas Huth, 2020/07/24