qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 0/7] coroutines: generate wrapper code


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v7 0/7] coroutines: generate wrapper code
Date: Mon, 27 Jul 2020 15:59:43 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

27.07.2020 15:48, Stefan Hajnoczi wrote:
On Wed, Jun 10, 2020 at 01:03:29PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Hi all!

The aim of the series is to reduce code-duplication and writing
parameters structure-packing by hand around coroutine function wrappers.

Benefits:
  - no code duplication
  - less indirection

Please add documentation so others know when and how to use this.

I suggest adding a docs/devel/coroutine-wrapper.rst document and adding
a code comment to #define generated_co_wrapper pointing to the
documentation.

Please rename coroutine-wrapper.py to block-coroutine-wrapper.py since
it is specific to the block layer.


OK, will do. Thanks for taking a look!


--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]