Re: [PATCH v1] virtio-mem-pci: force virtio version 1

[David Hildenbrand]

On 22.07.20 16:22, David Hildenbrand wrote:
> On 08.07.20 16:36, David Hildenbrand wrote:
>> Let's force virtio version 1. While at it, use qdev_realize() to set
>> the parent bus and realize - like most other virtio-*-pci
>> implementations.
>>
>> Fixes: 0b9a2443a48b ("virtio-pci: Proxy for virtio-mem")
>> Cc: Cornelia Huck <cohuck@redhat.com>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>>  hw/virtio/virtio-mem-pci.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/virtio/virtio-mem-pci.c b/hw/virtio/virtio-mem-pci.c
>> index 1a8e854123..831022aa86 100644
>> --- a/hw/virtio/virtio-mem-pci.c
>> +++ b/hw/virtio/virtio-mem-pci.c
>> @@ -21,8 +21,8 @@ static void virtio_mem_pci_realize(VirtIOPCIProxy 
>> *vpci_dev, Error **errp)
>>      VirtIOMEMPCI *mem_pci = VIRTIO_MEM_PCI(vpci_dev);
>>      DeviceState *vdev = DEVICE(&mem_pci->vdev);
>>  
>> -    qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus));
>> -    object_property_set_bool(OBJECT(vdev), true, "realized", errp);
>> +    virtio_pci_force_virtio_1(vpci_dev);
>> +    qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
>>  }
>>  
>>  static void virtio_mem_pci_set_addr(MemoryDeviceState *md, uint64_t addr,
>>
> 
> Ping @mst
> 

With Conny's patches in, simple virtio-mem examples currently fail with

qemu-system-x86_64: -device
virtio-mem-pci,id=vm0,memdev=mem0,node=0,requested-size=300M: device is
modern-only, use disable-legacy=on

So we really want this in QEMU 5.1

-- 
Thanks,

David / dhildenb