[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1] iotests: Select a default machine for the rx and avr
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH for-5.1] iotests: Select a default machine for the rx and avr targets |
Date: |
Fri, 24 Jul 2020 11:32:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Max/Kevin,
On 7/24/20 10:24 AM, Max Reitz wrote:
> On 22.07.20 18:19, Thomas Huth wrote:
>> If you are building only with either the new rx-softmmu or avr-softmmu
>> target, "make check-block" fails a couple of tests since there is no
>> default machine defined in these new targets. We have to select a machine
>> in the "check" script for these, just like we already do for the arm- and
>> tricore-softmmu targets.
I guess remember I already asked on IRC but can't find the log,
so better ask again on the list.
Why can't we use the 'none' machine for the block tests? What
part of the machines is required? I was thinking maybe busses,
but apparently not (example with these 2 machines).
Thanks,
Phil.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/qemu-iotests/check | 14 +++++++++-----
>> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> Thanks, applied to my block branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
>