[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] ide: rename cmd_write to ctrl_write
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/7] ide: rename cmd_write to ctrl_write |
|
Date: |
Fri, 24 Jul 2020 08:16:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/24/20 7:22 AM, John Snow wrote:
> It's the Control register, part of the Control block -- Command is
> misleading here. Rename all related functions and constants.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> include/hw/ide/internal.h | 9 +++++----
> hw/ide/core.c | 12 ++++++------
> hw/ide/ioport.c | 2 +-
> hw/ide/macio.c | 2 +-
> hw/ide/mmio.c | 8 ++++----
> hw/ide/pci.c | 12 ++++++------
> hw/ide/trace-events | 2 +-
> 7 files changed, 24 insertions(+), 23 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH 0/7] IDE: SRST and other fixes, John Snow, 2020/07/24
- [PATCH 2/7] ide: don't tamper with the device register, John Snow, 2020/07/24
- [PATCH 1/7] ide: rename cmd_write to ctrl_write, John Snow, 2020/07/24
- Re: [PATCH 1/7] ide: rename cmd_write to ctrl_write,
Philippe Mathieu-Daudé <=
- [PATCH 4/7] ide: reorder set/get sector functions, John Snow, 2020/07/24
- [PATCH 3/7] ide: model HOB correctly, John Snow, 2020/07/24
- [PATCH 6/7] ide: clear interrupt on command write, John Snow, 2020/07/24
- [PATCH 5/7] ide: remove magic constants from the device register, John Snow, 2020/07/24
- [PATCH 7/7] ide: cancel pending callbacks on SRST, John Snow, 2020/07/24