[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProto
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/3] scripts/qmp/qom-fuse: Unbreak import of QEMUMonitorProtocol |
Date: |
Thu, 23 Jul 2020 17:08:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/23/20 4:27 PM, Markus Armbruster wrote:
> Commit c7b942d7f8 "scripts/qmp: Fix shebang and imports" messed with
> it for reasons I don't quite understand. I do understand how it fails
> now: it neglects to import sys. Fix that.
Oops I missed that.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> It now fails because it expects an old version of module fuse. That's
> next.
>
> Fixes: c7b942d7f84ef54f266921bf7668d43f1f2c7c79
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qmp/qom-fuse | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse
> index 5fa6b3bf64..b7dabe8d65 100755
> --- a/scripts/qmp/qom-fuse
> +++ b/scripts/qmp/qom-fuse
> @@ -13,7 +13,7 @@
>
> import fuse, stat
> from fuse import Fuse
> -import os, posix
> +import os, posix, sys
> from errno import *
>
> sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..',
> 'python'))
> @@ -134,7 +134,7 @@ class QOMFS(Fuse):
> yield fuse.Direntry(str(item['name']))
>
> if __name__ == '__main__':
> - import sys, os
> + import os
>
> fs = QOMFS(QEMUMonitorProtocol(os.environ['QMP_SOCKET']))
> fs.main(sys.argv)
>