[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] spice: simplify chardev setup
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH] spice: simplify chardev setup |
Date: |
Wed, 22 Jul 2020 13:26:10 +0200 |
On Wed, Jul 22, 2020 at 11:20:31AM +0200, Christophe de Dinechin wrote:
>
> On 2020-07-22 at 10:49 CEST, Gerd Hoffmann wrote...
> > Initialize spice before chardevs. That allows to register the spice
> > chardevs directly in the init function and removes the need to maintain
> > a linked list of chardevs just for registration.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Looks good to me, but I still need to test how this integrates with my work
> on putting SPICE in a module.
Hope it simplifies things. Removes qemu_spice_register_ports(), so one
item less you have to wire up in QemuSpiceOps.
With the qom module bits being merged meanwhile too it should be easier
now to turn chardev/spice.c into a module.
take care,
Gerd