[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH-for-5.1 4/4] hw/avr/boot: Fix memory leak in avr_load_firmwar
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH-for-5.1 4/4] hw/avr/boot: Fix memory leak in avr_load_firmware() |
Date: |
Mon, 20 Jul 2020 15:18:06 +0100 |
User-agent: |
Mutt/1.14.5 (2020-06-23) |
On Tue, Jul 14, 2020 at 06:42:57PM +0200, Philippe Mathieu-Daudé wrote:
> The value returned by qemu_find_file() must be freed.
>
> This fixes Coverity issue CID 1430449, which points out
> that the memory returned by qemu_find_file() is leaked.
>
> Fixes: Coverity CID 1430449 (RESOURCE_LEAK)
> Fixes: 7dd8f6fde4 ('hw/avr: Add support for loading ELF/raw binaries')
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/avr/boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/avr/boot.c b/hw/avr/boot.c
> index 6fbcde4061..151734f82d 100644
> --- a/hw/avr/boot.c
> +++ b/hw/avr/boot.c
> @@ -60,7 +60,7 @@ static const char *avr_elf_e_flags_to_cpu_type(uint32_t
> flags)
> bool avr_load_firmware(AVRCPU *cpu, MachineState *ms,
> MemoryRegion *program_mr, const char *firmware)
> {
> - const char *filename;
> + g_autofree char *filename;
Any variable marked g_autofree or g_auto must always be initialized
to NULL otherwise there's risk of free'ing uninitialized data. Even
if currently safe, any later refactoring could turn it into a bug.
So iff "= NULL" is added:
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH-for-5.1 0/4] misc: Document qemu_find_file and fix memory leak in avr_load_firmware, Philippe Mathieu-Daudé, 2020/07/14
- [PATCH-for-5.1 1/4] qemu/osdep: Document os_find_datadir() return value, Philippe Mathieu-Daudé, 2020/07/14
- [PATCH-for-5.1 2/4] qemu/osdep: Reword qemu_get_exec_dir() documentation, Philippe Mathieu-Daudé, 2020/07/14
- [PATCH-for-5.1 4/4] hw/avr/boot: Fix memory leak in avr_load_firmware(), Philippe Mathieu-Daudé, 2020/07/14
- [PATCH-for-5.1 3/4] qemu-common: Document qemu_find_file(), Philippe Mathieu-Daudé, 2020/07/14
- Re: [PATCH-for-5.1 0/4] misc: Document qemu_find_file and fix memory leak in avr_load_firmware, Michael Rolnik, 2020/07/20
- Re: [PATCH-for-5.1 0/4] misc: Document qemu_find_file and fix memory leak in avr_load_firmware, Philippe Mathieu-Daudé, 2020/07/20