qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] usb: only build hcd-dwc2 host controller for RASPI target


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] usb: only build hcd-dwc2 host controller for RASPI target
Date: Fri, 17 Jul 2020 09:50:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 7/17/20 3:05 AM, Paul Zimmerman wrote:
> The hcd-dwc2 host controller is currently built for all targets.
> Since for now hcd-dwc2 is only implemented on RASPI, restrict its
> build to that target only.
> 
> Signed-off-by: Paul Zimmerman <pauldzim@gmail.com>
> ---
> 
> Hi Gerd,
> 
> Do we want to apply this before the 5.1.0 release? It seems a waste
> to build this code for every target when it's only used on one.
> Sorry I didn't realize this earlier.

Not a big deal ;)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> 
> Thanks,
> Paul
> 
>  hw/arm/Kconfig | 1 +
>  hw/usb/Kconfig | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 4a224a6351..bc3a423940 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -315,6 +315,7 @@ config RASPI
>      select FRAMEBUFFER
>      select PL011 # UART
>      select SDHCI
> +    select USB_DWC2
>  
>  config STM32F205_SOC
>      bool
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index d4d8c37c28..5e63dc75f8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -48,7 +48,6 @@ config USB_MUSB
>  
>  config USB_DWC2
>      bool
> -    default y
>      select USB
>  
>  config TUSB6010
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]