Re: [PATCH-for-5.2 1/5] hw/core/qdev-properties: Simplify get_reserved_region()

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Use the safer g_strdup_printf() over snprintf() + abort().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/core/qdev-properties.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
> index 098298c78e..d5f5aa150b 100644
> --- a/hw/core/qdev-properties.c
> +++ b/hw/core/qdev-properties.c
> @@ -581,13 +581,10 @@ static void get_reserved_region(Object *obj, Visitor 
> *v, const char *name,
>      DeviceState *dev = DEVICE(obj);
>      Property *prop = opaque;
>      ReservedRegion *rr = qdev_get_prop_ptr(dev, prop);
> -    char buffer[64];
> -    char *p = buffer;
> -    int rc;
> +    g_autofree char *p;
>  
> -    rc = snprintf(buffer, sizeof(buffer), "0x%"PRIx64":0x%"PRIx64":%u",
> -                  rr->low, rr->high, rr->type);
> -    assert(rc < sizeof(buffer));
> +    p = g_strdup_printf("0x%"PRIx64":0x%"PRIx64":%u",
> +                        rr->low, rr->high, rr->type);
>  
>      visit_type_str(v, name, &p, errp);
>  }

I don't buy "safer" (the old code is already safe).  I could buy
"simpler".

It's also less efficient, but that shouldn't matter in a property
getter.