[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] linux-user: Add strace support for printing arguments for io
|
From: |
no-reply |
|
Subject: |
Re: [PATCH] linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines |
|
Date: |
Tue, 14 Jul 2020 13:54:30 -0700 (PDT) |
Patchew URL:
20200714200439.11328-1-Filip.Bozuta@syrmia.com/">https://patchew.org/QEMU/20200714200439.11328-1-Filip.Bozuta@syrmia.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200714200439.11328-1-Filip.Bozuta@syrmia.com
Subject: [PATCH] linux-user: Add strace support for printing arguments for
ioctls used for terminals and serial lines
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
d2628b1..8bfa25a master -> master
Switched to a new branch 'test'
ae9f19a linux-user: Add strace support for printing arguments for ioctls used
for terminals and serial lines
=== OUTPUT BEGIN ===
ERROR: storage class should be at the beginning of the declaration
#75: FILE: linux-user/strace.c:1196:
+UNUSED static struct flags termios_iflags[] = {
ERROR: storage class should be at the beginning of the declaration
#93: FILE: linux-user/strace.c:1214:
+UNUSED static struct flags termios_oflags[] = {
ERROR: storage class should be at the beginning of the declaration
#105: FILE: linux-user/strace.c:1226:
+UNUSED static struct flags termios_oflags_NLDLY[] = {
ERROR: storage class should be at the beginning of the declaration
#111: FILE: linux-user/strace.c:1232:
+UNUSED static struct flags termios_oflags_CRDLY[] = {
ERROR: storage class should be at the beginning of the declaration
#119: FILE: linux-user/strace.c:1240:
+UNUSED static struct flags termios_oflags_TABDLY[] = {
ERROR: storage class should be at the beginning of the declaration
#127: FILE: linux-user/strace.c:1248:
+UNUSED static struct flags termios_oflags_VTDLY[] = {
ERROR: storage class should be at the beginning of the declaration
#133: FILE: linux-user/strace.c:1254:
+UNUSED static struct flags termios_oflags_FFDLY[] = {
ERROR: storage class should be at the beginning of the declaration
#139: FILE: linux-user/strace.c:1260:
+UNUSED static struct flags termios_oflags_BSDLY[] = {
ERROR: storage class should be at the beginning of the declaration
#145: FILE: linux-user/strace.c:1266:
+UNUSED static struct flags termios_cflags_CBAUD[] = {
ERROR: storage class should be at the beginning of the declaration
#169: FILE: linux-user/strace.c:1290:
+UNUSED static struct flags termios_cflags_CSIZE[] = {
ERROR: storage class should be at the beginning of the declaration
#177: FILE: linux-user/strace.c:1298:
+UNUSED static struct flags termios_cflags[] = {
ERROR: storage class should be at the beginning of the declaration
#188: FILE: linux-user/strace.c:1309:
+UNUSED static struct flags termios_lflags[] = {
total: 12 errors, 0 warnings, 260 lines checked
Commit ae9f19a165a6 (linux-user: Add strace support for printing arguments for
ioctls used for terminals and serial lines) has style problems, please review.
If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20200714200439.11328-1-Filip.Bozuta@syrmia.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200714200439.11328-1-Filip.Bozuta@syrmia.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com