[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-5.1 1/5] qdev: Fix device_add DRIVER, help to print to monito
From: |
Markus Armbruster |
Subject: |
[PATCH for-5.1 1/5] qdev: Fix device_add DRIVER, help to print to monitor |
Date: |
Tue, 14 Jul 2020 18:01:58 +0200 |
Help on device properties gets printed to stdout instead of the
monitor. If you have the monitor anywhere else, no help for you.
Broken when commit e1043d674d "qdev: use object_property_help()"
accidentally switched from qemu_printf() to printf(). Switch right
back.
Fixes: e1043d674d792ff64aebae1a3eafc08b38a8a085
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qdev-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index 71ebce19df..e9b7228480 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -300,7 +300,7 @@ int qdev_device_help(QemuOpts *opts)
}
g_ptr_array_sort(array, (GCompareFunc)qemu_pstrcmp0);
for (i = 0; i < array->len; i++) {
- printf("%s\n", (char *)array->pdata[i]);
+ qemu_printf("%s\n", (char *)array->pdata[i]);
}
g_ptr_array_set_free_func(array, g_free);
g_ptr_array_free(array, true);
--
2.26.2
- [PATCH for-5.1 0/5] qom: HMP command fixes, Markus Armbruster, 2020/07/14
- [PATCH for-5.1 4/5] qom: Document object_get_canonical_path() returns malloced string, Markus Armbruster, 2020/07/14
- [PATCH for-5.1 5/5] qom: Make info qom-tree sort children more efficiently, Markus Armbruster, 2020/07/14
- [PATCH for-5.1 2/5] qom: Plug memory leak in "info qom-tree", Markus Armbruster, 2020/07/14
- [PATCH for-5.1 1/5] qdev: Fix device_add DRIVER, help to print to monitor,
Markus Armbruster <=
- [PATCH for-5.1 3/5] qom: Change object_get_canonical_path_component() not to malloc, Markus Armbruster, 2020/07/14