Re: [PULL 0/7] Linux user for 5.1 patches

[no-reply]

Patchew URL: 
20200714073259.1464675-1-laurent@vivier.eu/">https://patchew.org/QEMU/20200714073259.1464675-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200714073259.1464675-1-laurent@vivier.eu
Subject: [PULL 0/7] Linux user for 5.1 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ffeb691 linux-user: fix print_syscall_err() when syscall returned value is 
negative
415b123 linux-user: fix the errno value in print_syscall_err()
75a05ad linux-user: add netlink RTM_SETLINK command
124e290 linux-user: add new netlink types
2fb1965 linux-user: Fix Coverity CID 1430271 / CID 1430272
178a436 linux-user: refactor ipc syscall and support of semtimedop syscall
7901fa7 linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols

=== OUTPUT BEGIN ===
1/7 Checking commit 7901fa78df84 (linux-user: Use EPROTONOSUPPORT for 
unimplemented netlink protocols)
2/7 Checking commit 178a436bfe2d (linux-user: refactor ipc syscall and support 
of semtimedop syscall)
WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:820:
+#ifdef __s390x__

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:3894:
+#ifdef __s390x__

ERROR: Macros with complex values should be enclosed in parenthesis
#63: FILE: linux-user/syscall.c:3895:
+#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \
+  (__nsops), (__timeout), (__sops)

ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: linux-user/syscall.c:3898:
+#define SEMTIMEDOP_IPC_ARGS(__nsops, __sops, __timeout) \
+  (__nsops), 0, (__sops), (__timeout)

WARNING: architecture specific defines should be avoided
#111: FILE: linux-user/syscall.c:4093:
+#ifdef __s390x__

WARNING: architecture specific defines should be avoided
#125: FILE: linux-user/syscall.c:4108:
+#ifdef __NR_ipc

WARNING: architecture specific defines should be avoided
#126: FILE: linux-user/syscall.c:4109:
+#if defined(__sparc__)

ERROR: Macros with complex values should be enclosed in parenthesis
#128: FILE: linux-user/syscall.c:4111:
+#define MSGRCV_ARGS(__msgp, __msgtyp) __msgp, __msgtyp

ERROR: Macros with complex values should be enclosed in parenthesis
#134: FILE: linux-user/syscall.c:4117:
+#define MSGRCV_ARGS(__msgp, __msgtyp) \
+    ((long int[]){(long int)__msgp, __msgtyp}), 0

total: 4 errors, 5 warnings, 153 lines checked

Patch 2/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/7 Checking commit 2fb19656ca9e (linux-user: Fix Coverity CID 1430271 / CID 
1430272)
4/7 Checking commit 124e290931a2 (linux-user: add new netlink types)
5/7 Checking commit 75a05adf0c46 (linux-user: add netlink RTM_SETLINK command)
6/7 Checking commit 415b12395796 (linux-user: fix the errno value in 
print_syscall_err())
7/7 Checking commit ffeb69146ef6 (linux-user: fix print_syscall_err() when 
syscall returned value is negative)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200714073259.1464675-1-laurent@vivier.eu/testing.checkpatch/?type=message">http://patchew.org/logs/20200714073259.1464675-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com