[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 12/12] python/machine.py: change default wait timeout to 3
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH v5 12/12] python/machine.py: change default wait timeout to 3 seconds |
|
Date: |
Tue, 14 Jul 2020 00:20:00 -0400 |
On Fri, Jul 10, 2020 at 01:06:49AM -0400, John Snow wrote:
> Machine.wait() does not appear to be used except in the acceptance tests,
> and an infinite timeout by default in a test suite is not the most helpful.
>
> Change it to 3 seconds, like the default shutdown timeout.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Well, for the acceptance tests, there's usually a test wide timeout,
but this is indeed a good idea!
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
[PATCH v5 10/12] python/machine.py: split shutdown into hard and soft flavors, John Snow, 2020/07/10
[PATCH v5 12/12] python/machine.py: change default wait timeout to 3 seconds, John Snow, 2020/07/10
[PATCH v5 11/12] python/machine.py: re-add sigkill warning suppression, John Snow, 2020/07/10
Re: [PATCH v5 00/12] python/machine.py: refactor shutdown, Philippe Mathieu-Daudé, 2020/07/14