[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] migration/migration.c: Remove superfluous breaks
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 3/3] migration/migration.c: Remove superfluous breaks |
Date: |
Mon, 13 Jul 2020 14:33:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/13/20 2:23 PM, Juan Quintela wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
I hadn't reviewed this patch, but now I did ¯\_(ツ)_/¯
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> migration/migration.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 08519de56f..2ed9923227 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -986,7 +986,6 @@ static void fill_source_migration_info(MigrationInfo
> *info)
> /* no migration has happened ever */
> /* do not overwrite destination migration status */
> return;
> - break;
> case MIGRATION_STATUS_SETUP:
> info->has_status = true;
> info->has_total_time = false;
> @@ -1105,7 +1104,6 @@ static void
> fill_destination_migration_info(MigrationInfo *info)
> switch (mis->state) {
> case MIGRATION_STATUS_NONE:
> return;
> - break;
> case MIGRATION_STATUS_SETUP:
> case MIGRATION_STATUS_CANCELLING:
> case MIGRATION_STATUS_CANCELLED:
>