Re: [PATCH v2 0/4] Add strace support for printing arguments for a group of selected syscalls

[no-reply]

Patchew URL: 
20200713095058.106624-1-Filip.Bozuta@syrmia.com/">https://patchew.org/QEMU/20200713095058.106624-1-Filip.Bozuta@syrmia.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200713095058.106624-1-Filip.Bozuta@syrmia.com
Subject: [PATCH v2 0/4] Add strace support for printing arguments for a group 
of selected syscalls

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
773d300 linux-user: Add strace support for printing arguments of some clock and 
time functions
c0f4fd3 linux-user: Add strace support for printing arguments of syscalls used 
to lock and unlock memory
bef93ac linux-user: Add strace support for printing arguments of 
truncate()/ftruncate() and getsid()
6601cfb linux-user: Make cpu_env accessible in strace.c

=== OUTPUT BEGIN ===
1/4 Checking commit 6601cfb1b081 (linux-user: Make cpu_env accessible in 
strace.c)
2/4 Checking commit bef93ac02143 (linux-user: Add strace support for printing 
arguments of truncate()/ftruncate() and getsid())
3/4 Checking commit c0f4fd3df8ce (linux-user: Add strace support for printing 
arguments of syscalls used to lock and unlock memory)
ERROR: storage class should be at the beginning of the declaration
#336: FILE: linux-user/strace.c:1201:
+UNUSED static struct flags mlockall_flags[] = {

total: 1 errors, 0 warnings, 307 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 773d300f9a0f (linux-user: Add strace support for printing 
arguments of some clock and time functions)
ERROR: storage class should be at the beginning of the declaration
#58: FILE: linux-user/strace.c:67:
+UNUSED static void print_timespec(abi_ulong, int);

ERROR: storage class should be at the beginning of the declaration
#60: FILE: linux-user/strace.c:69:
+UNUSED static void print_itimer_type(abi_ulong, int);

ERROR: storage class should be at the beginning of the declaration
#61: FILE: linux-user/strace.c:70:
+UNUSED static void print_itimerval(abi_ulong, int);

total: 3 errors, 0 warnings, 299 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200713095058.106624-1-Filip.Bozuta@syrmia.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200713095058.106624-1-Filip.Bozuta@syrmia.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com