[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/12] tcg/riscv: Remove superfluous breaks
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 03/12] tcg/riscv: Remove superfluous breaks |
Date: |
Mon, 13 Jul 2020 12:37:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/13/20 11:04 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
I hadn't reviewed this patch, but now I did.
> ---
> tcg/riscv/tcg-target.inc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
> index 2bc0ba7..3c11ab8 100644
> --- a/tcg/riscv/tcg-target.inc.c
> +++ b/tcg/riscv/tcg-target.inc.c
> @@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int
> type,
> break;
> case R_RISCV_JAL:
> return reloc_jimm20(code_ptr, (tcg_insn_unit *)value);
> - break;
> case R_RISCV_CALL:
> return reloc_call(code_ptr, (tcg_insn_unit *)value);
> - break;
> default:
> tcg_abort();
> }
>