[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] configure: fix incorrect have_keyring check
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/1] configure: fix incorrect have_keyring check |
Date: |
Mon, 13 Jul 2020 11:00:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Alexey,
On 7/13/20 10:55 AM, Alexey Kirillov wrote:
> In some shells, we can't use == sign (as example, in dash).
>
> Signed-off-by: Alexey Kirillov <lekiravi@yandex-team.ru>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 31e2ddbf28..f65914f98f 100755
> --- a/configure
> +++ b/configure
> @@ -6486,7 +6486,7 @@ EOF
> fi
> if test "$secret_keyring" != "no"
> then
> - if test "$have_keyring" == "yes"
> + if test "$have_keyring" = "yes"
> then
> secret_keyring=yes
> else
>
Thanks, but David already sent the same fix:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg713765.html
It should be merged in today or tomorrow via Alex Bennée tree.