Re: [PATCH 3/3] cpu-timers, icount: new modules

[Claudio Fontana]

On 7/11/20 12:45 AM, Paolo Bonzini wrote:
> On 10/07/20 06:36, Thomas Huth wrote:
>>
>> In short this goes away if I again set icount to enabled for qtest,
>> basically ensuring that --enable-tcg is there and then reenabling icount.
>>
>> qtest was forcing icount and shift=0 by creating qemu options, in order to 
>> misuse its counter feature,
>> instead of using a separate counter.
> 
> Why would it need a separate counter?  In both cases it's a
> manually-updated counter that is used for QEMU_CLOCK_VIRTUAL.  The only
> difference is that shift > 0 doesn't make sense for qtest.
> 
> Paolo
> 

I think I would reverse the question. Why reuse for qtest a counter that has 
absolutely nothing to do with it?

qtest has nothing to do with instruction counting.

Keeping the relationship between qtest and the icount module means that
functionality of icount cannot be carved out into a separate module that is 
only included with tcg.

Ciao,

CLaudio