Re: Is VXHS actually maintained?

[Peter Maydell]

On Thu, 9 Jul 2020 at 16:42, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Thu, Jul 9, 2020 at 7:30 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>>
>> On Thu, 9 Jul 2020 at 16:27, Daniel P. Berrangé <berrange@redhat.com> wrote:
>> > If it doesn't even compile, do we even need to go through the full
>> > deprecation cycle ? I tend to feel like the release where it first
>> > fails to compile automatically starts the deprecation countdown.
>>
>> Mmm, assuming that it's "couldn't possibly compile for anybody"
>> rather than "doesn't compile for me (but maybe it would be OK
>> on some other host OS config)".
>>
>> Marc-André, what are the details of the compilation failure?
>
>
>
> I have done some release bisection.
>
> v2.11.0 compiles, v2.12.0 started failing with:
>
>   CC      block/vxhs.o
> /home/elmarco/src/qq/block/vxhs.c:126:1: error: variable ‘runtime_opts’ has 
> initializer but incomplete type
>   126 | static QemuOptsList runtime_opts = {
>       | ^~~~~~
> /home/elmarco/src/qq/block/vxhs.c:127:6: error: ‘QemuOptsList’ has no member 
> named ‘name’

Missing include, probably. Anyway, if it's been broken like
that since 2.12 then I think we can reasonably deduce that
nobody can possibly have been using it and just remove it.

thanks
-- PMM