[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3 |
Date: |
Wed, 8 Jul 2020 23:24:04 +0200 |
On Jul 8 19:19, Dmitry Fomichev wrote:
> Looks good with a small nit (see below),
>
> Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
>
> >
> On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > +#define NVME_TEMP_TMPTH(temp) ((temp >> 0) & 0xffff)
>
> There is an extra space after temp >>
>
Good catch! I won't repost for this ;) - but I'll fix it and add it in
the qemu-nvme tree.
[PATCH v3 02/18] hw/block/nvme: fix missing endian conversion, Klaus Jensen, 2020/07/06
[PATCH v3 06/18] hw/block/nvme: mark fw slot 1 as read-only, Klaus Jensen, 2020/07/06
[PATCH v3 05/18] hw/block/nvme: add temperature threshold feature, Klaus Jensen, 2020/07/06