qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v7 03/47] block: bdrv_cow_child() for bdrv_has_zero_init()


From: Andrey Shinkevich
Subject: Re: [PATCH v7 03/47] block: bdrv_cow_child() for bdrv_has_zero_init()
Date: Wed, 8 Jul 2020 20:23:46 +0300
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.9.0


On 25.06.2020 18:21, Max Reitz wrote:
bdrv_has_zero_init() and the related bdrv_unallocated_blocks_are_zero()
should use bdrv_cow_child() if they want to check whether the given BDS
has a COW backing file.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
  block.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block.c b/block.c
index 0a0b855261..f3e2aae49c 100644
--- a/block.c
+++ b/block.c
@@ -5394,7 +5394,7 @@ int bdrv_has_zero_init(BlockDriverState *bs)
/* If BS is a copy on write image, it is initialized to
         the contents of the base image, which may not be zeroes.  */
-    if (bs->backing) {
+    if (bdrv_cow_child(bs)) {
          return 0;
      }
      if (bs->drv->bdrv_has_zero_init) {
@@ -5412,7 +5412,7 @@ bool bdrv_unallocated_blocks_are_zero(BlockDriverState 
*bs)
  {
      BlockDriverInfo bdi;
- if (bs->backing) {
+    if (bdrv_cow_child(bs)) {
          return false;
      }
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]