qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] tests: Skip over pcrUpdateCounter byte in result comp


From: Stefan Berger
Subject: Re: [PATCH v2 2/2] tests: Skip over pcrUpdateCounter byte in result comparison
Date: Tue, 7 Jul 2020 13:43:41 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 7/7/20 4:19 AM, David Gibson wrote:
On Tue, Jul 07, 2020 at 12:05:22AM -0400, Stefan Berger wrote:
Due to a change in the TPM 2 code the pcrUpdate counter in the
PCRRead response is now different, so we skip comparison of the
14th byte.
Can you elaborate on this a bit, both in the code comment and the
commit message.


Will do in v3. Basically the TPM 2 code has been 'fixed' to reflect the pcclient profile more closely and due to the change in PCRs that belong to the 'TCB group' the response of the TPM2_Pcrread command now returns a slightly different value for the pcrUpdateCounter value, which unfortunately breaks the test cases. Leaving the TPM 2 as it was wasn't a long-term option.

https://github.com/stefanberger/libtpms/commit/0f5d791a7d3431a6831086f5a186cc53149f695f





reply via email to

[Prev in Thread] Current Thread [Next in Thread]