Re: Slow down with: 'Make "info qom-tree" show children sorted'

[Paolo Bonzini]

On 07/07/20 11:40, Daniel P. Berrangé wrote:
> 
> The info qom-tree calls could be pushed outside the loop
> 
>    info qom-tree
>    for each device type
>       device_addr type,help
>    info qom-tree
> 
> Taking /x86_64/device/introspect/concrete/defaults/pc-q35-5.1 as a
> example, this change is the difference between 20 seconds running and
> 3 seconds running.

Or even, saving half the runtime:

    info qom-tree
    for each device type
       device_addr type,help
       info qom-tree

Paolo

> Reverting Markus' change actually didn't make much difference, only
> reducing the 20 seconds to 17 seconds.
> 
> The downside is that if there is a stray object/crash, it would not
> immediately associate with the device type. I'm not sure that's a
> real problem though. Especially if we are running this as pre-merge
> CI we'll only need to look at the patch series to find the broken
> device. If this is quick enough that we can run it as standard,
> instead of only with -m slow, then its a net win I think.