[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 1/2] hw/sd/ssi-sd: Deprecate the SPI to SD card 'adapter'
|
From: |
Peter Krempa |
|
Subject: |
Re: [RFC PATCH 1/2] hw/sd/ssi-sd: Deprecate the SPI to SD card 'adapter' |
|
Date: |
Tue, 7 Jul 2020 08:47:32 +0200 |
|
User-agent: |
Mutt/1.14.3 (2020-06-14) |
On Mon, Jul 06, 2020 at 00:07:30 +0200, Philippe Mathieu-Daudé wrote:
> This device duplicate the SPI mode of the sd-card device. The
> SPI protocol is better handler in the sd-card, however as the
> TYPE_SSI_SLAVE is not an interface, the sd-card can not implement
> it easily to be pluggable on a SPI bus. Meanwhile the ssi-sd
> device acts as a bridge, but is bitroting. Deprecate it.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> docs/system/deprecated.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 47f84be8e0..5e67d7f3e0 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -343,6 +343,11 @@ The 'ide-drive' device is deprecated. Users should use
> 'ide-hd' or
> The 'scsi-disk' device is deprecated. Users should use 'scsi-hd' or
> 'scsi-cd' as appropriate to get a SCSI hard disk or CD-ROM as needed.
>
> +``ssi-sd`` (since 5.1)
> +'''''''''''''''''''''''''
> +
> +The 'ssi-sd' (SSI to SD card adapter) device is deprecated.
libvirt didn't allow configuring this device yet, so from our view it's
okay to remove it.
ACKed-by: Peter Krempa <pkrempa@redhat.com>