[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Fix mtedesc for do_mem_zpz
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] target/arm: Fix mtedesc for do_mem_zpz |
|
Date: |
Tue, 7 Jul 2020 04:08:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/6/20 10:23 PM, Richard Henderson wrote:
> The mtedesc that was contructed was not actually passed in.
Typo "constructed".
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Found by Coverity (CID 1429996).
>
> Fixes: d28d12f008e
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/translate-sve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
> index 08f0fd15b2..88a2fb271d 100644
> --- a/target/arm/translate-sve.c
> +++ b/target/arm/translate-sve.c
> @@ -5275,7 +5275,7 @@ static void do_mem_zpz(DisasContext *s, int zt, int pg,
> int zm,
> desc = FIELD_DP32(desc, MTEDESC, ESIZE, 1 << msz);
> desc <<= SVE_MTEDESC_SHIFT;
> }
> - desc = simd_desc(vsz, vsz, scale);
> + desc = simd_desc(vsz, vsz, desc | scale);
> t_desc = tcg_const_i32(desc);
>
> tcg_gen_addi_ptr(t_pg, cpu_env, pred_full_reg_offset(s, pg));
>