Re: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze

[no-reply]

Patchew URL: 
20200706164155.24696-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20200706164155.24696-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/53] Misc patches for QEMU 5.1 soft freeze
Type: series
Message-id: 20200706164155.24696-1-pbonzini@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200630133912.9428-1-f4bug@amsat.org -> 
patchew/20200630133912.9428-1-f4bug@amsat.org
 - [tag update]      patchew/20200704144943.18292-1-f4bug@amsat.org -> 
patchew/20200704144943.18292-1-f4bug@amsat.org
 * [new tag]         patchew/20200706164155.24696-1-pbonzini@redhat.com -> 
patchew/20200706164155.24696-1-pbonzini@redhat.com
Switched to a new branch 'test'
7f86007 scripts: improve message when TAP based tests fail
7248fcd target/i386: Enable TSX Suspend Load Address Tracking feature
866c9c9 target/i386: Add SERIALIZE cpu feature
167c040 target/i386/kvm: Simplify kvm_get_supported_[feature]_msrs()
c84e280 target/i386/kvm: Simplify kvm_get_mce_cap_supported()
4307708 target/i386/kvm: Simplify get_para_features()
35ba753 accel/kvm: Simplify kvm_check_extension_list()
658563b accel/kvm: Simplify kvm_check_extension()
7c2d8c7 accel/kvm: Let kvm_check_extension use global KVM state
4f09921 softmmu/vl: Remove the check for colons in -accel parameters
aae19bd cpu-timers, icount: new modules
d4c3bd1 cpu-throttle: new module, extracted from cpus.c
3f0a1ca softmmu: move softmmu only files from root
0f5f394 pc: fix leak in pc_system_flash_cleanup_unused
d14fbbb cpus: Move CPU code from exec.c to cpus-common.c
6b5e15e target/i386: Correct the warning message of Intel PT
06d34e2 checkpatch: Change occurences of 'kernel' to 'qemu' in user messages
a797e70 iscsi: return -EIO when sense fields are meaningless
483b353 iscsi: handle check condition status in retry loop
45968d9 target/i386: sev: fail query-sev-capabilities if QEMU cannot use SEV
3991cda target/i386: sev: provide proper error reporting for 
query-sev-capabilities
56fee26 KVM: x86: believe what KVM says about WAITPKG
c2cad97 target/i386: implement undocumented "smsw r32" behavior
0820d30 target/i386: remove gen_io_end
a808c08e Makefile: simplify MINIKCONF rules
492710d accel/tcg: Add stub for probe_access()
9968331 accel/Kconfig: Add the TCG selector
15af609 accel/Kconfig: Extract accel selectors into their own config
f2c9a72 Makefile: Write MINIKCONF variables as one entry per line
e34b354 Makefile: Remove dangerous EOL trailing backslash
e8ca3d5 MAINTAINERS: Cover the HAX accelerator stub
5cf8ecc MAINTAINERS: Add an 'overall' entry for accelerators
828b5c8 MAINTAINERS: Fix KVM path expansion glob
2b33834 MAINTAINERS: Add Cameron as HVF co-maintainer
f83bafe i386: hvf: Clean up synchronize functions
5546118 i386: hvf: Don't duplicate register reset
0100693 i386: hvf: Move Guest LMA reset to macvm_set_cr0()
50ad1f9 i386: hvf: Make long mode enter and exit clearer
7391fcc i386: hvf: Add hvf_cpu_synchronize_pre_loadvm()
d9b7a7b i386: hvf: Move synchronize functions to sysemu
76f44ff i386: hvf: Set env->eip in macvm_set_rip()
4a75f22 coverity: provide Coverity-friendly MIN_CONST and MAX_CONST
8928cb9 KVM: add support for AMD nested live migration
89f8144 target/i386: fix IEEE SSE floating-point exception raising
9140f0b target/i386: set SSE FTZ in correct floating-point state
d38f9f1 hw/core/null-machine: Do not initialize unused chardev backends
c9a48de tests/qmp-cmd-test: Add qmp/object-add-failure-modes
704157d tests/qmp-cmd-test: Add qmp/object-add-duplicate-id
ddc8b9c qom: Introduce object_property_try_add_child()
82cfec7 util/qemu-error: prepend guest name to error message to identify 
affected VM owner
af648d9 tests: Inject test name also when the test fails
033c1b7 tcg/svm: use host cr4 during NPT page table walk

=== OUTPUT BEGIN ===
1/52 Checking commit 033c1b717196 (tcg/svm: use host cr4 during NPT page table 
walk)
2/52 Checking commit af648d9d91aa (tests: Inject test name also when the test 
fails)
3/52 Checking commit 82cfec7d2eab (util/qemu-error: prepend guest name to error 
message to identify affected VM owner)
4/52 Checking commit ddc8b9c5389f (qom: Introduce 
object_property_try_add_child())
5/52 Checking commit 704157dd905c (tests/qmp-cmd-test: Add 
qmp/object-add-duplicate-id)
6/52 Checking commit c9a48de829c1 (tests/qmp-cmd-test: Add 
qmp/object-add-failure-modes)
7/52 Checking commit d38f9f107573 (hw/core/null-machine: Do not initialize 
unused chardev backends)
8/52 Checking commit 9140f0b9bb43 (target/i386: set SSE FTZ in correct 
floating-point state)
9/52 Checking commit 89f8144f4e84 (target/i386: fix IEEE SSE floating-point 
exception raising)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#312: 
new file mode 100644

ERROR: Use of volatile is usually wrong, please add a comment
#323: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:7:
+volatile float f_res;

ERROR: Use of volatile is usually wrong, please add a comment
#324: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:8:
+volatile double d_res;

ERROR: Use of volatile is usually wrong, please add a comment
#326: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:10:
+volatile float f_snan = __builtin_nansf("");

ERROR: Use of volatile is usually wrong, please add a comment
#327: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:11:
+volatile float f_half = 0.5f;

ERROR: Use of volatile is usually wrong, please add a comment
#328: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:12:
+volatile float f_third = 1.0f / 3.0f;

ERROR: Use of volatile is usually wrong, please add a comment
#329: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:13:
+volatile float f_nan = __builtin_nanl("");

ERROR: Use of volatile is usually wrong, please add a comment
#330: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:14:
+volatile float f_inf = __builtin_inff();

ERROR: Use of volatile is usually wrong, please add a comment
#331: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:15:
+volatile float f_ninf = -__builtin_inff();

ERROR: Use of volatile is usually wrong, please add a comment
#332: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:16:
+volatile float f_one = 1.0f;

ERROR: Use of volatile is usually wrong, please add a comment
#333: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:17:
+volatile float f_two = 2.0f;

ERROR: Use of volatile is usually wrong, please add a comment
#334: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:18:
+volatile float f_zero = 0.0f;

ERROR: Use of volatile is usually wrong, please add a comment
#335: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:19:
+volatile float f_nzero = -0.0f;

ERROR: Use of volatile is usually wrong, please add a comment
#336: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:20:
+volatile float f_min = FLT_MIN;

ERROR: spaces required around that '-' (ctx:VxV)
#337: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:21:
+volatile float f_true_min = 0x1p-149f;
                                 ^

ERROR: Use of volatile is usually wrong, please add a comment
#337: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:21:
+volatile float f_true_min = 0x1p-149f;

ERROR: Use of volatile is usually wrong, please add a comment
#338: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:22:
+volatile float f_max = FLT_MAX;

ERROR: Use of volatile is usually wrong, please add a comment
#339: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:23:
+volatile float f_nmax = -FLT_MAX;

ERROR: Use of volatile is usually wrong, please add a comment
#341: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:25:
+volatile double d_snan = __builtin_nans("");

ERROR: Use of volatile is usually wrong, please add a comment
#342: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:26:
+volatile double d_half = 0.5;

ERROR: Use of volatile is usually wrong, please add a comment
#343: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:27:
+volatile double d_third = 1.0 / 3.0;

ERROR: Use of volatile is usually wrong, please add a comment
#344: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:28:
+volatile double d_nan = __builtin_nan("");

ERROR: Use of volatile is usually wrong, please add a comment
#345: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:29:
+volatile double d_inf = __builtin_inf();

ERROR: Use of volatile is usually wrong, please add a comment
#346: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:30:
+volatile double d_ninf = -__builtin_inf();

ERROR: Use of volatile is usually wrong, please add a comment
#347: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:31:
+volatile double d_one = 1.0;

ERROR: Use of volatile is usually wrong, please add a comment
#348: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:32:
+volatile double d_two = 2.0;

ERROR: Use of volatile is usually wrong, please add a comment
#349: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:33:
+volatile double d_zero = 0.0;

ERROR: Use of volatile is usually wrong, please add a comment
#350: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:34:
+volatile double d_nzero = -0.0;

ERROR: Use of volatile is usually wrong, please add a comment
#351: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:35:
+volatile double d_min = DBL_MIN;

ERROR: spaces required around that '-' (ctx:VxV)
#352: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:36:
+volatile double d_true_min = 0x1p-1074;
                                  ^

ERROR: Use of volatile is usually wrong, please add a comment
#352: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:36:
+volatile double d_true_min = 0x1p-1074;

ERROR: Use of volatile is usually wrong, please add a comment
#353: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:37:
+volatile double d_max = DBL_MAX;

ERROR: Use of volatile is usually wrong, please add a comment
#354: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:38:
+volatile double d_nmax = -DBL_MAX;

ERROR: Use of volatile is usually wrong, please add a comment
#356: FILE: tests/tcg/i386/test-i386-sse-exceptions.c:40:
+volatile int32_t i32_max = INT32_MAX;

total: 33 errors, 1 warnings, 1033 lines checked

Patch 9/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/52 Checking commit 8928cb91c066 (KVM: add support for AMD nested live 
migration)
11/52 Checking commit 4a75f22d725a (coverity: provide Coverity-friendly 
MIN_CONST and MAX_CONST)
WARNING: architecture specific defines should be avoided
#59: FILE: include/qemu/osdep.h:269:
+#ifdef __COVERITY__

total: 0 errors, 1 warnings, 43 lines checked

Patch 11/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/52 Checking commit 76f44ffc910f (i386: hvf: Set env->eip in macvm_set_rip())
13/52 Checking commit d9b7a7b91271 (i386: hvf: Move synchronize functions to 
sysemu)
14/52 Checking commit 7391fccb4503 (i386: hvf: Add 
hvf_cpu_synchronize_pre_loadvm())
15/52 Checking commit 50ad1f938adf (i386: hvf: Make long mode enter and exit 
clearer)
16/52 Checking commit 0100693ac7a2 (i386: hvf: Move Guest LMA reset to 
macvm_set_cr0())
17/52 Checking commit 554611882eb3 (i386: hvf: Don't duplicate register reset)
18/52 Checking commit f83bafef5a99 (i386: hvf: Clean up synchronize functions)
19/52 Checking commit 2b3383479e0d (MAINTAINERS: Add Cameron as HVF 
co-maintainer)
20/52 Checking commit 828b5c8302e9 (MAINTAINERS: Fix KVM path expansion glob)
21/52 Checking commit 5cf8ecc8f350 (MAINTAINERS: Add an 'overall' entry for 
accelerators)
22/52 Checking commit e8ca3d539b13 (MAINTAINERS: Cover the HAX accelerator stub)
23/52 Checking commit e34b3545f9a6 (Makefile: Remove dangerous EOL trailing 
backslash)
24/52 Checking commit f2c9a722a19c (Makefile: Write MINIKCONF variables as one 
entry per line)
25/52 Checking commit 15af6093c279 (accel/Kconfig: Extract accel selectors into 
their own config)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 32 lines checked

Patch 25/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/52 Checking commit 9968331c3247 (accel/Kconfig: Add the TCG selector)
27/52 Checking commit 492710dfc756 (accel/tcg: Add stub for probe_access())
28/52 Checking commit a808c08ef0d8 (Makefile: simplify MINIKCONF rules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 28 lines checked

Patch 28/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/52 Checking commit 0820d3077474 (target/i386: remove gen_io_end)
30/52 Checking commit c2cad9776a49 (target/i386: implement undocumented "smsw 
r32" behavior)
31/52 Checking commit 56fee26334f0 (KVM: x86: believe what KVM says about 
WAITPKG)
32/52 Checking commit 3991cda076dd (target/i386: sev: provide proper error 
reporting for query-sev-capabilities)
33/52 Checking commit 45968d9ca1b9 (target/i386: sev: fail 
query-sev-capabilities if QEMU cannot use SEV)
34/52 Checking commit 483b353452de (iscsi: handle check condition status in 
retry loop)
35/52 Checking commit a797e707f8ab (iscsi: return -EIO when sense fields are 
meaningless)
36/52 Checking commit 06d34e2e7bbb (checkpatch: Change occurences of 'kernel' 
to 'qemu' in user messages)
37/52 Checking commit 6b5e15e3daec (target/i386: Correct the warning message of 
Intel PT)
38/52 Checking commit d14fbbb355b8 (cpus: Move CPU code from exec.c to 
cpus-common.c)
39/52 Checking commit 0f5f394e08c5 (pc: fix leak in 
pc_system_flash_cleanup_unused)
40/52 Checking commit 3f0a1caeda2a (softmmu: move softmmu only files from root)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#123: 
rename from arch_init.c

total: 0 errors, 1 warnings, 83 lines checked

Patch 40/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
41/52 Checking commit d4c3bd176306 (cpu-throttle: new module, extracted from 
cpus.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#106: 
new file mode 100644

total: 0 errors, 1 warnings, 396 lines checked

Patch 41/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
42/52 Checking commit aae19bd9ead0 (cpu-timers, icount: new modules)
WARNING: line over 80 characters
#110: FILE: accel/tcg/cpu-exec.c:107:
+            qemu_printf("Warning: The guest is now late by %.1f to %.1f 
seconds\n",

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#424: 
new file mode 100644

total: 0 errors, 2 warnings, 2430 lines checked

Patch 42/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
43/52 Checking commit 4f099211e22d (softmmu/vl: Remove the check for colons in 
-accel parameters)
44/52 Checking commit 7c2d8c7d13ca (accel/kvm: Let kvm_check_extension use 
global KVM state)
45/52 Checking commit 658563be1173 (accel/kvm: Simplify kvm_check_extension())
ERROR: space prohibited after that open parenthesis '('
#138: FILE: accel/kvm/kvm-all.c:2125:
+        kvm_check_extension( KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2);

total: 1 errors, 0 warnings, 757 lines checked

Patch 45/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

46/52 Checking commit 35ba7530aa2c (accel/kvm: Simplify 
kvm_check_extension_list())
47/52 Checking commit 43077084eb85 (target/i386/kvm: Simplify 
get_para_features())
48/52 Checking commit c84e280ac321 (target/i386/kvm: Simplify 
kvm_get_mce_cap_supported())
49/52 Checking commit 167c0409c6dc (target/i386/kvm: Simplify 
kvm_get_supported_[feature]_msrs())
50/52 Checking commit 866c9c9b3cc2 (target/i386: Add SERIALIZE cpu feature)
51/52 Checking commit 7248fcd37ec6 (target/i386: Enable TSX Suspend Load 
Address Tracking feature)
WARNING: Block comments use a leading /* on a separate line
#32: FILE: target/i386/cpu.c:990:
+            "tsx-ldtrk", NULL, NULL /* pconfig */, NULL,

total: 0 errors, 1 warnings, 16 lines checked

Patch 51/52 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
52/52 Checking commit 7f86007e8aa6 (scripts: improve message when TAP based 
tests fail)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200706164155.24696-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200706164155.24696-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com