Re: [PATCH v3 28/44] qom: Use returned bool to check for failure, manual

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 28/44] qom: Use returned bool to check for failure, manual

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part
Date:	Mon, 6 Jul 2020 19:39:33 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 06.07.2020 11:09, Markus Armbruster wrote:

The previous commit used Coccinelle to convert from checking the Error
object to checking the return value.  Convert a few more manually.

Signed-off-by: Markus Armbruster<armbru@redhat.com>
Reviewed-by: Eric Blake<eblake@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 27/44] qom: Use returned bool to check for failure, Coccinelle part, (continued)
- [PATCH v3 27/44] qom: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 27/44] qom: Use returned bool to check for failure, Coccinelle part, Vladimir Sementsov-Ogievskiy, 2020/07/06
- [PATCH v3 34/44] error: Eliminate error_propagate() with Coccinelle, part 2, Markus Armbruster, 2020/07/06
- [PATCH v3 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/06
- [PATCH v3 19/44] s390x/pci: Fix harmless mistake in zpci's property fid's setter, Markus Armbruster, 2020/07/06
- [PATCH v3 05/44] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Markus Armbruster, 2020/07/06
- [PATCH v3 41/44] error: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2020/07/06
- [PATCH v3 44/44] hmp: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/07/06
- [PATCH v3 32/44] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/06
- [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part, Vladimir Sementsov-Ogievskiy <=
- [PATCH v3 35/44] error: Eliminate error_propagate() manually, Markus Armbruster, 2020/07/06
- [PATCH v3 25/44] qom: Put name parameter before value / visitor parameter, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 25/44] qom: Put name parameter before value / visitor parameter, Vladimir Sementsov-Ogievskiy, 2020/07/06
- Re: [PATCH v3 00/44] Less clumsy error checking, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 00/44] Less clumsy error checking, Eric Blake, 2020/07/06
- [PATCH v3 43/44] qdev: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/07/06
- [PATCH v3 42/44] qemu-img: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/07/06
- [PATCH v3 37/44] block/parallels: Simplify parallels_open() after previous commit, Markus Armbruster, 2020/07/06
- [PATCH v3 33/44] error: Eliminate error_propagate() with Coccinelle, part 1, Markus Armbruster, 2020/07/06

Prev by Date: Re: [PATCH v5 11/21] virtio-pci: Proxy for virtio-mem
Next by Date: Re: [PATCH v7 12/17] hw/sd/sdcard: Simplify cmd_valid_while_locked()
Previous by thread: [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part
Next by thread: [PATCH v3 35/44] error: Eliminate error_propagate() manually
Index(es):
- Date
- Thread