Re: [PATCH v3 26/44] qom: Make functions taking Error ** return bool, n

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 26/44] qom: Make functions taking Error ** return bool, n

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v3 26/44] qom: Make functions taking Error ** return bool, not void
Date:	Mon, 6 Jul 2020 18:44:27 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

06.07.2020 11:09, Markus Armbruster wrote:

See recent commit "error: Document Error API usage rules" for
rationale.

Signed-off-by: Markus Armbruster<armbru@redhat.com>
Reviewed-by: Eric Blake<eblake@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 31/44] qdev: Use returned bool to check for failure, Coccinelle part, (continued)
- [PATCH v3 31/44] qdev: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/06
- [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1, Vladimir Sementsov-Ogievskiy, 2020/07/06
    - Re: [PATCH v3 29/44] qom: Make functions taking Error ** return bool, not 0/-1, Markus Armbruster, 2020/07/06
- [PATCH v3 23/44] qom: Don't handle impossible object_property_get_link() failure, Markus Armbruster, 2020/07/06
- [PATCH v3 20/44] qom: Use error_reportf_err() instead of g_printerr() in examples, Markus Armbruster, 2020/07/06
- [PATCH v3 36/44] error: Reduce unnecessary error propagation, Markus Armbruster, 2020/07/06
- [PATCH v3 12/44] qemu-option: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/06
- [PATCH v3 39/44] qapi: Smooth visitor error checking in generated code, Markus Armbruster, 2020/07/06
- [PATCH v3 26/44] qom: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 26/44] qom: Make functions taking Error ** return bool, not void, Vladimir Sementsov-Ogievskiy <=
- [PATCH v3 27/44] qom: Use returned bool to check for failure, Coccinelle part, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 27/44] qom: Use returned bool to check for failure, Coccinelle part, Vladimir Sementsov-Ogievskiy, 2020/07/06
- [PATCH v3 34/44] error: Eliminate error_propagate() with Coccinelle, part 2, Markus Armbruster, 2020/07/06
- [PATCH v3 16/44] qapi: Make visitor functions taking Error ** return bool, not void, Markus Armbruster, 2020/07/06
- [PATCH v3 19/44] s390x/pci: Fix harmless mistake in zpci's property fid's setter, Markus Armbruster, 2020/07/06
- [PATCH v3 05/44] virtio-crypto-pci: Tidy up virtio_crypto_pci_realize(), Markus Armbruster, 2020/07/06
- [PATCH v3 41/44] error: Avoid error_propagate() after migrate_add_blocker(), Markus Armbruster, 2020/07/06
- [PATCH v3 44/44] hmp: Ignore Error objects where the return value suffices, Markus Armbruster, 2020/07/06
- [PATCH v3 32/44] error: Avoid unnecessary error_propagate() after error_setg(), Markus Armbruster, 2020/07/06
- [PATCH v3 28/44] qom: Use returned bool to check for failure, manual part, Markus Armbruster, 2020/07/06

Prev by Date: Re: [PATCH 0/6] migration: bring savevm/loadvm/delvm over to QMP
Next by Date: Re: [PATCH 0/6] migration: bring savevm/loadvm/delvm over to QMP
Previous by thread: [PATCH v3 26/44] qom: Make functions taking Error ** return bool, not void
Next by thread: [PATCH v3 27/44] qom: Use returned bool to check for failure, Coccinelle part
Index(es):
- Date
- Thread