[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 08/23] hw/display/ramfb: Emit warning when old code is
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [RFC PATCH v2 08/23] hw/display/ramfb: Emit warning when old code is used |
|
Date: |
Mon, 6 Jul 2020 16:18:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/6/20 4:15 PM, Gerd Hoffmann wrote:
> On Sat, Jul 04, 2020 at 05:38:53PM +0200, Philippe Mathieu-Daudé wrote:
>> This code hasn't been QOM'ified yet. Warn the user.
>
> False positive IMHO. This is designed to be integrated into other
> devices for boot display. vfio/display.c uses it that way. There
> also is a standalone version (initially meant to be used for testing
> only, but turned out to be useful on arm) in ramfb-standalone.c which
> is a proper QOM object too.
OK, good to know.
I guess I should take the time to comment the false positives too in the
code (Paolo made various other comments too). So next developer won't
have to ask again.
- [PATCH v2 01/23] qom/object: Update documentation, (continued)
- [PATCH v2 01/23] qom/object: Update documentation, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 02/23] hw/core/qdev: Add qdev_warn_deprecated_function_used() helper, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 03/23] hw/arm/omap: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 05/23] hw/arm/nseries: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 04/23] hw/arm/pxa2xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 07/23] hw/display/blizzard: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 06/23] hw/char/parallel: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 08/23] hw/display/ramfb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 09/23] hw/display/tc6393xb: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 10/23] hw/display/vga-isa-mm: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 11/23] hw/dma/etraxfs_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 13/23] hw/input/lasips2: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 12/23] hw/dma/soc_dma: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 14/23] hw/input/tsc2005: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 15/23] hw/m68k/mcf520x: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 16/23] hw/misc/cbus: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04
- [RFC PATCH v2 17/23] hw/nvram/eeprom93xx: Emit warning when old code is used, Philippe Mathieu-Daudé, 2020/07/04