[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/10] Modules 20200702 patches
From: |
Gerd Hoffmann |
Subject: |
Re: [PULL 00/10] Modules 20200702 patches |
Date: |
Mon, 6 Jul 2020 15:20:41 +0200 |
Hi,
> >>> build: fix device module builds
> >> No code review at all? :-(
> >
> > Well, there have been 5 revisions on the list, partly due to bugs being
> > fixed, partly with changes as response to review comments. So it got
> > some review (not much though) even though the v5 series (posted on June
> > 22th, so there was more than a week time) didn't got any acks so far.
> >
> >> In particular the "build: fix device module
> >> builds" commit (as you note in your commit message) does not look at
> >> all right.
> >
> > I think this stop-gap will do fine as long as we don't have any
> > target-specific modules.
>
> Yeah, it's hackish but target-specific modules would be a huge
> complication so I don't think we'd be having them anytime soon. With
> Meson removing the unnest-vars logic, the hack would also go away on its
> own. So I guess it's okay.
OK, good. So how to go forward now?
(1) Merge pull req as-is?
(2) Re-spin with discussion summary added to patch "4/10 build: fix
device module builds".
(3) Something else?
Any chance for an ack in case we go (2) or (3) ?
thanks & take care,
Gerd
- [PULL 05/10] ccid: build smartcard as module, (continued)
- [PULL 05/10] ccid: build smartcard as module, Gerd Hoffmann, 2020/07/02
- [PULL 01/10] module: qom module support, Gerd Hoffmann, 2020/07/02
- [PULL 06/10] usb: build usb-redir as module, Gerd Hoffmann, 2020/07/02
- [PULL 10/10] chardev: enable modules, use for braille, Gerd Hoffmann, 2020/07/02
- [PULL 08/10] vga: build virtio-gpu only once, Gerd Hoffmann, 2020/07/02
- [PULL 07/10] vga: build qxl as module, Gerd Hoffmann, 2020/07/02
- [PULL 09/10] vga: build virtio-gpu as module, Gerd Hoffmann, 2020/07/02
- Re: [PULL 00/10] Modules 20200702 patches, Peter Maydell, 2020/07/03
- Re: [PULL 00/10] Modules 20200702 patches, Claudio Fontana, 2020/07/03