Re: [PATCH v3 24/44] qom: Use return values to check for error where tha

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 24/44] qom: Use return values to check for error where tha

From:	Vladimir Sementsov-Ogievskiy
Subject:	Re: [PATCH v3 24/44] qom: Use return values to check for error where that's simpler
Date:	Mon, 6 Jul 2020 14:23:16 +0300
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

06.07.2020 11:09, Markus Armbruster wrote:

When using the Error object to check for error, we need to receive it
into a local variable, then propagate() it to @errp.

Using the return value permits allows receiving it straight to @errp.

Signed-off-by: Markus Armbruster<armbru@redhat.com>
Reviewed-by: Eric Blake<eblake@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 11/44] qemu-option: Replace opt_set() by cleaner opt_validate(), (continued)
- [PATCH v3 11/44] qemu-option: Replace opt_set() by cleaner opt_validate(), Markus Armbruster, 2020/07/06
- [PATCH v3 01/44] error: Improve examples in error.h's big comment, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 01/44] error: Improve examples in error.h's big comment, Markus Armbruster, 2020/07/06
- [PATCH v3 04/44] macio: Tidy up error handling in macio_newworld_realize(), Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 04/44] macio: Tidy up error handling in macio_newworld_realize(), Greg Kurz, 2020/07/06
- [PATCH v3 07/44] qemu-option: Make uses of find_desc_by_name() more similar, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 07/44] qemu-option: Make uses of find_desc_by_name() more similar, Greg Kurz, 2020/07/07
- [PATCH v3 09/44] qemu-option: Simplify around find_default_by_name(), Markus Armbruster, 2020/07/06
- [PATCH v3 14/44] block: Avoid error accumulation in bdrv_img_create(), Markus Armbruster, 2020/07/06
- [PATCH v3 24/44] qom: Use return values to check for error where that's simpler, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 24/44] qom: Use return values to check for error where that's simpler, Vladimir Sementsov-Ogievskiy <=
- [PATCH v3 02/44] error: Document Error API usage rules, Markus Armbruster, 2020/07/06
- [PATCH v3 15/44] hmp: Eliminate a variable in hmp_migrate_set_parameter(), Markus Armbruster, 2020/07/06
- [PATCH v3 08/44] qemu-option: Factor out helper find_default_by_name(), Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 08/44] qemu-option: Factor out helper find_default_by_name(), Greg Kurz, 2020/07/07
- [PATCH v3 22/44] qom: Crash more nicely on object_property_get_link() failure, Markus Armbruster, 2020/07/06
- [PATCH v3 21/44] qom: Rename qdev_get_type() to object_get_type(), Markus Armbruster, 2020/07/06
- [PATCH v3 10/44] qemu-option: Factor out helper opt_create(), Markus Armbruster, 2020/07/06
- [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient, Markus Armbruster, 2020/07/06
  - Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient, Greg Kurz, 2020/07/06
    - Re: [PATCH v3 06/44] qemu-option: Check return value instead of @err where convenient, Markus Armbruster, 2020/07/06

Prev by Date: Re: [PULL 13/14] virtio-ccw: fix virtio_set_ind_atomic
Next by Date: Re: [PULL 14/14] s390x/pci: fix set_ind_atomic
Previous by thread: [PATCH v3 24/44] qom: Use return values to check for error where that's simpler
Next by thread: [PATCH v3 02/44] error: Document Error API usage rules
Index(es):
- Date
- Thread