Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

[Jason Wang]

On 2020/7/1 下午8:41, Peter Xu wrote:
> On Wed, Jul 01, 2020 at 08:30:07PM +0800, Jason Wang wrote:
> > > I overlooked myself that the IR region will be there even if ir=off.
> >
> > Yes, but the point stands still but the issue is still if ir=off.
> >
> >
> > >     So I
> > > think the assert should stand.
> >
> > Do you mean vhost can't trigger the assert()? If yes, I don't get how it
> > can't.
> Yes.  vhost can only trigger the translate() via memory API.  No matter whether
> ir is on/off, the memory region is always enabled, so any access to 0xfeexxxxx
> from memory API should still land at s->mr_ir, afaict, rather than the dmar 
> region.


Right.

Thanks

>