[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/2] net: tap: check file descriptor can be used
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 0/2] net: tap: check file descriptor can be used |
Date: |
Tue, 30 Jun 2020 16:12:35 +0100 |
User-agent: |
Mutt/1.14.3 (2020-06-14) |
On Tue, Jun 30, 2020 at 04:57:35PM +0200, Laurent Vivier wrote:
> v2: Add patch from Daniel to check the fd can be used
>
> I have updated Daniel's patch not to check for EINVAL on TUNGETIFF
> as I think we can avoid this special case because TUNGETIFF
> is available since kernel v2.6.27 (October 2008)
> Moreover I think the code was wrong as it was checking with -EINVAL and
> not EINVAL.
Agreed, given our documented OS platform targets, we don't need to
care about such old kernels.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|