qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] linux-user/elfload: use MAP_FIXED in pgb_reserved_va


From: Peter Maydell
Subject: Re: [PATCH] linux-user/elfload: use MAP_FIXED in pgb_reserved_va
Date: Tue, 30 Jun 2020 14:10:01 +0100

On Tue, 30 Jun 2020 at 11:36, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> Given we assert the requested address matches what we asked we should
> also make that clear in the mmap flags. Otherwise we see failures in
> the GitLab environment for some currently unknown but allowable
> reason.

Adding MAP_FIXED will mean that instead of failing if there's
something else already at that address, the kernel will now
silently blow that away in favour of the new mapping. Is
that definitely what we want here ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]