[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces
From: |
Klaus Jensen |
Subject: |
[PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces |
Date: |
Tue, 30 Jun 2020 12:01:29 +0200 |
From: Klaus Jensen <k.jensen@samsung.com>
Hi all,
This series adds support for TP 4056 ("Namespace Types") and TP 4053
("Zoned Namespaces") and is an alternative implementation to the one
submitted by Dmitry[1].
While I don't want this to end up as a discussion about the merits of
each version, I want to point out a couple of differences from Dmitry's
version. At a glance, my version
* builds on my patch series that adds fairly complete NVMe v1.4
mandatory support, as well as nice-to-have feature such as SGLs,
multiple namespaces and mostly just overall clean up. This finally
brings the nvme device into a fairly compliant state on which we can
add new features. I've tried hard to get these compliance and
clean-up patches merged for a long time (in parallel with developing
the emulation of NST and ZNS) and I would be really sad to see them
by-passed since they have already been through many iterations and
already carries Acked- and Reviewed-by's for the bulk of the
patches. I think the nvme device is already in a "frankenstate" wrt.
the implemented nvme version and the features it currently supports,
so I think this kind of cleanup is long overdue.
* uses an attached blockdev and standard blk_aio for persistent zone
info. This is the same method used in our patches for Write
Uncorrectable and (separate and extended lba) metadata support, but
I've left those optional features out for now to ease the review
process.
* relies on the universal dulbe support added in ("hw/block/nvme: add
support for dulbe") and sparse images for handling reads in gaps
(above write pointer and below ZSZE); that is - the size of the
underlying blockdev is in terms of ZSZE, not ZCAP
* the controller uses timers to autonomously finish zones (wrt. FRL)
I've been on paternity leave for a month, so I havn't been around to
review Dmitry's patches, but I have started that process now. I would
also be happy to work with Dmitry & Friends on merging our versions to
get the best of both worlds if it makes sense.
This series and all preparatory patch sets (the ones I've been posting
yesterday and today) are available on my GitHub[2]. Unfortunately
Patchew got screwed up in the middle of me sending patches and it never
picked up v2 of "hw/block/nvme: support multiple namespaces" because it
was getting late and I made a mistake with the CC's. So my posted series
don't apply according to Patchew, but they actually do if you follow the
Based-on's (... or just grab [2]).
[1]: Message-Id: <20200617213415.22417-1-dmitry.fomichev@wdc.com>
[2]: https://github.com/birkelund/qemu/tree/for-master/nvme
Based-on: <20200630043122.1307043-1-its@irrelevant.dk>
("[PATCH 0/3] hw/block/nvme: bump to v1.4")
Klaus Jensen (10):
hw/block/nvme: support I/O Command Sets
hw/block/nvme: add zns specific fields and types
hw/block/nvme: add basic read/write for zoned namespaces
hw/block/nvme: add the zone management receive command
hw/block/nvme: add the zone management send command
hw/block/nvme: add the zone append command
hw/block/nvme: track and enforce zone resources
hw/block/nvme: allow open to close transitions by controller
hw/block/nvme: allow zone excursions
hw/block/nvme: support reset/finish recommended limits
block/nvme.c | 6 +-
hw/block/nvme-ns.c | 397 +++++++++-
hw/block/nvme-ns.h | 148 +++-
hw/block/nvme.c | 1676 +++++++++++++++++++++++++++++++++++++++--
hw/block/nvme.h | 76 +-
hw/block/trace-events | 43 +-
include/block/nvme.h | 252 ++++++-
7 files changed, 2469 insertions(+), 129 deletions(-)
--
2.27.0
- [PATCH 00/10] hw/block/nvme: namespace types and zoned namespaces,
Klaus Jensen <=
- [PATCH 01/10] hw/block/nvme: support I/O Command Sets, Klaus Jensen, 2020/06/30
- [PATCH 05/10] hw/block/nvme: add the zone management send command, Klaus Jensen, 2020/06/30
- [PATCH 03/10] hw/block/nvme: add basic read/write for zoned namespaces, Klaus Jensen, 2020/06/30
- [PATCH 04/10] hw/block/nvme: add the zone management receive command, Klaus Jensen, 2020/06/30
- [PATCH 02/10] hw/block/nvme: add zns specific fields and types, Klaus Jensen, 2020/06/30
- [PATCH 08/10] hw/block/nvme: allow open to close transitions by controller, Klaus Jensen, 2020/06/30
- [PATCH 09/10] hw/block/nvme: allow zone excursions, Klaus Jensen, 2020/06/30
- [PATCH 06/10] hw/block/nvme: add the zone append command, Klaus Jensen, 2020/06/30
- [PATCH 10/10] hw/block/nvme: support reset/finish recommended limits, Klaus Jensen, 2020/06/30
- [PATCH 07/10] hw/block/nvme: track and enforce zone resources, Klaus Jensen, 2020/06/30