[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/9] nvram: add nrf51_soc flash read method
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v2 5/9] nvram: add nrf51_soc flash read method |
|
Date: |
Mon, 29 Jun 2020 17:31:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 29/06/20 13:17, Li Qiang wrote:
> The 'flash_ops' is for ROM, though I don't see where it calls
> 'memory_region_rom_device_set_romd'
> to ROMD, so this MR is in MMIO mode and it needs a read callback.
>
> However as the origin code doesn't provide a read callback. So why
> here we return something?
>
> I prefer here just 'qemu_log_mask(LOG_UNIMP, "%s not implemented\n",
> __func__);' as other
> patches does.
Even abort() would do (with a comment).
Paolo
- Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods, (continued)
[PATCH v2 6/9] spapr_pci: add spapr msi read method, P J P, 2020/06/24
[PATCH v2 8/9] imx7-ccm: add digprog mmio write method, P J P, 2020/06/24
Re: [PATCH v2 0/9] memory: assert and define MemoryRegionOps callbacks, no-reply, 2020/06/24