[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 09/30] tests/vm: change scripts to use self._config
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 09/30] tests/vm: change scripts to use self._config |
Date: |
Mon, 29 Jun 2020 12:06:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/26/20 8:13 PM, Alex Bennée wrote:
> From: Robert Foley <robert.foley@linaro.org>
>
> This change converts existing scripts to using for example self.ROOT_PASS,
> to self._config['root_pass'].
> We made similar changes for GUEST_USER, and GUEST_PASS.
> This allows us also to remove the change in basevm.py,
> which adds __getattr__ for backwards compatibility.
>
> Signed-off-by: Robert Foley <robert.foley@linaro.org>
> Reviewed-by: Peter Puhov <peter.puhov@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20200601211421.1277-8-robert.foley@linaro.org>
> ---
> tests/vm/basevm.py | 11 ++---------
> tests/vm/fedora | 17 +++++++++--------
> tests/vm/freebsd | 16 ++++++++--------
> tests/vm/netbsd | 19 ++++++++++---------
> tests/vm/openbsd | 17 +++++++++--------
> 5 files changed, 38 insertions(+), 42 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v3 00/30] testing/next (gitlab, vm, docker), Alex Bennée, 2020/06/26
- [PATCH v3 01/30] iotests: Fix 051 output after qdev_init_nofail() removal, Alex Bennée, 2020/06/26
- [PATCH v3 02/30] crypto/linux_keyring: fix 'secret_keyring' configure test, Alex Bennée, 2020/06/26
- [PATCH v3 03/30] tests/vm: pass args through to BaseVM's __init__, Alex Bennée, 2020/06/26
- [PATCH v3 04/30] tests/vm: Add configuration to basevm.py, Alex Bennée, 2020/06/26
- [PATCH v3 05/30] tests/vm: Added configuration file support, Alex Bennée, 2020/06/26
- [PATCH v3 07/30] tests/vm: Added a new script for ubuntu.aarch64., Alex Bennée, 2020/06/26
- [PATCH v3 06/30] tests/vm: Add common Ubuntu python module, Alex Bennée, 2020/06/26
- [PATCH v3 09/30] tests/vm: change scripts to use self._config, Alex Bennée, 2020/06/26
- Re: [PATCH v3 09/30] tests/vm: change scripts to use self._config,
Philippe Mathieu-Daudé <=
- [PATCH v3 18/30] gitlab: introduce explicit "container" and "build" stages, Alex Bennée, 2020/06/26
- [PATCH v3 12/30] tests/vm: switch from optsparse to argparse, Alex Bennée, 2020/06/26
- [PATCH v3 08/30] tests/vm: Added a new script for centos.aarch64., Alex Bennée, 2020/06/26
- [PATCH v3 10/30] python/qemu: Add ConsoleSocket for optional use in QEMUMachine, Alex Bennée, 2020/06/26
- [PATCH v3 11/30] tests/vm: Add workaround to consume console, Alex Bennée, 2020/06/26
- [PATCH v3 17/30] gitlab-ci: Fix the change rules after moving the YML files, Alex Bennée, 2020/06/26
- [PATCH v3 21/30] gitlab: build containers with buildkit and metadata, Alex Bennée, 2020/06/26
- [PATCH v3 13/30] tests/vm: allow us to take advantage of MTTCG, Alex Bennée, 2020/06/26
- [PATCH v3 30/30] containers.yml: build with docker.py tooling, Alex Bennée, 2020/06/26
- [PATCH v3 16/30] .gitignore: un-ignore .gitlab-ci.d, Alex Bennée, 2020/06/26