Re: [PATCH v2 0/3] trace: Add a trace backend for the recorder library

[no-reply]

Patchew URL: 
20200626162706.3304357-1-dinechin@redhat.com/">https://patchew.org/QEMU/20200626162706.3304357-1-dinechin@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 0/3] trace: Add a trace backend for the recorder library
Type: series
Message-id: 20200626162706.3304357-1-dinechin@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   10f7ffa..87fb952  master     -> master
 - [tag update]      patchew/20200626151424.30117-1-peter.maydell@linaro.org -> 
patchew/20200626151424.30117-1-peter.maydell@linaro.org
 * [new tag]         patchew/20200626162706.3304357-1-dinechin@redhat.com -> 
patchew/20200626162706.3304357-1-dinechin@redhat.com
Switched to a new branch 'test'
850bed5 trace: Example of "centralized" recorder tracing
1f9a8da trace: Add support for recorder back-end
76dd7c6 Makefile: Compute libraries for libqemuutil.a and libvhost-user.a

=== OUTPUT BEGIN ===
1/3 Checking commit 76dd7c67fe5e (Makefile: Compute libraries for libqemuutil.a 
and libvhost-user.a)
2/3 Checking commit 1f9a8daea6eb (trace: Add support for recorder back-end)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#130: 
new file mode 100644

WARNING: line over 80 characters
#182: FILE: scripts/tracetool/backend/recorder.py:48:
+        out('RECORDER_DEFINE(%(name)s, 8, "Tracetool recorder for 
%(api)s(%(args)s)");',

ERROR: do not use C99 // comments
#247: FILE: trace/recorder.c:18:
+    // Allow a dump in case we receive some unhandled signal

ERROR: do not use C99 // comments
#248: FILE: trace/recorder.c:19:
+    // For example, send USR2 to a hung process to get a dump

ERROR: braces {} are necessary for all arms of this statement
#249: FILE: trace/recorder.c:20:
+    if (getenv("RECORDER_TRACES"))
[...]

ERROR: space required after that ',' (ctx:VxV)
#250: FILE: trace/recorder.c:21:
+        recorder_dump_on_common_signals(0,0);
                                          ^

ERROR: do not use C99 // comments
#281: FILE: trace/recorder.h:24:
+// Disable recorder macros

ERROR: do not use C99 // comments
#289: FILE: trace/recorder.h:32:
+#endif // CONFIG_TRACE_RECORDER

ERROR: do not use C99 // comments
#291: FILE: trace/recorder.h:34:
+#endif // TRACE_RECORDER_H

ERROR: do not use C99 // comments
#312: FILE: util/module.c:158:
+        // New recorders may have been pulled in, activate them if necessary

total: 8 errors, 2 warnings, 237 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 850bed523e63 (trace: Example of "centralized" recorder 
tracing)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200626162706.3304357-1-dinechin@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200626162706.3304357-1-dinechin@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com