Re: [PATCH v2] build: Haiku build fix

[no-reply]

Patchew URL: 
https://patchew.org/QEMU/CA+XhMqy_bAnWm3cByobn+4LkVoAEZk3DU2=kWBcdB4m1b2Cd0g@mail.gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2] build: Haiku build fix
Type: series
Message-id: CA+XhMqy_bAnWm3cByobn+4LkVoAEZk3DU2=kWBcdB4m1b2Cd0g@mail.gmail.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   beafab8..63d2119  master     -> master
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/CA+XhMqy_bAnWm3cByobn+4LkVoAEZk3DU2=kWBcdB4m1b2Cd0g@mail.gmail.com -> 
patchew/CA+XhMqy_bAnWm3cByobn+4LkVoAEZk3DU2=kWBcdB4m1b2Cd0g@mail.gmail.com
Switched to a new branch 'test'
65ac93a build: Haiku build fix

=== OUTPUT BEGIN ===
WARNING: architecture specific defines should be avoided
#98: FILE: include/qemu/osdep.h:391:
+#if defined(__HAIKU__)

ERROR: return of an errno should typically be -ve (return -ENOSYS)
#122: FILE: os-posix.c:350:
+    return ENOSYS;

WARNING: architecture specific defines should be avoided
#172: FILE: util/oslib-posix.c:41:
+#if !defined(__HAIKU__)

total: 1 errors, 2 warnings, 149 lines checked

Commit 65ac93a6bfe2 (build: Haiku build fix) has style problems, please review. 
 If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/CA+XhMqy_bAnWm3cByobn+4LkVoAEZk3DU2=kWBcdB4m1b2Cd0g@mail.gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com