Re: [RFC 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

[no-reply]

Patchew URL: 20200625191651.5817-1-eperezma@redhat.com/">https://patchew.org/QEMU/20200625191651.5817-1-eperezma@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [RFC 0/1] memory: Delete assertion in 
memory_region_unregister_iommu_notifier
Type: series
Message-id: 20200625191651.5817-1-eperezma@redhat.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200625191651.5817-1-eperezma@redhat.com -> 
patchew/20200625191651.5817-1-eperezma@redhat.com
Switched to a new branch 'test'
3dcb120 memory: Delete assertion in memory_region_unregister_iommu_notifier

=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#24: FILE: memory.c:1918:
+    // assert(entry->iova >= notifier->start && entry_end <= notifier->end);

total: 1 errors, 0 warnings, 8 lines checked

Commit 3dcb1204223a (memory: Delete assertion in 
memory_region_unregister_iommu_notifier) has style problems, please review.  If 
any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200625191651.5817-1-eperezma@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200625191651.5817-1-eperezma@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com